Fixes and Improvements for Modifying Cron Jobs #515
Conversation
Martinski4GitHub
commented
Sep 2, 2025
Martinski4GitHub
commented
- Fixed bug when checking and modifying the cron job to schedule the Automatic F/W Updates checks.
- Improved code when checking and modifying the cron job to schedule the Automatic Script Update checks.
- Fixed bug when checking and modifying the cron job to schedule the Automatic F/W Updates checks. - Improved code when checking and modifying the cron job to schedule the Automatic Script Update checks.
|
While you were working on the "Time Picker" changes, I took a deeper dive into the code dealing with adding the cron job schedules to try to figure out what had happened and find any root cause. Well, the issue was that the code that was making the decision whether to add the cron job was not checking for and testing against the exact time schedule parameters; it was checking only for the script path and cron job tag, so when a new time was set, the existing checks thought that the cron job was already created. I have now fixed those issues on this PR. While your fix worked for one situation, it was really only a "band-aid" since a deeper analysis was needed to find the root cause. Also, your fix was adding the cron job without checking to see whether "Automatic F/W Updates" were actually enabled. Please review and test when you have a chance. |
|
Good to go! |
2 participants
